Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added feature to simplify adding wire:click functionality to row elements #591

Merged
merged 5 commits into from
Jan 21, 2022

Conversation

adamwoodhead
Copy link
Contributor

@adamwoodhead adamwoodhead commented Dec 13, 2021

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

This pull request adds the ability to add a "wire:click" to your row element, an alternative to a URL & Target, for if/when you're making a SPA.

No automated tests have been included - testing has been done manually, no conflicts could be found, and the table continues to work with and without the use of the added feature.

@stale
Copy link

stale bot commented Jan 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jan 13, 2022
@rappasoft
Copy link
Owner

Bump

@stale stale bot removed the wontfix This will not be worked on label Jan 13, 2022
@rappasoft rappasoft added the Awaiting Next Release Currently merged into development awaiting a release to master label Jan 21, 2022
@rappasoft rappasoft mentioned this pull request Jan 21, 2022
@rappasoft rappasoft merged commit 6efecfe into rappasoft:master Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Next Release Currently merged into development awaiting a release to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants